feat: 500 response if the node proxy request fails #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of silently dropping the request, pass a 500 to the proxy consumer.
jbergstroem
changed the title
sapphi-red
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
This is written in the docs of http-proxy.
Also I confirmed it works.
patak-dev
changed the title
This was referenced Jul 14, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If node-proxy encounters an error (be it in how its set up or issues with fulfilling the request such as
ECONNREFUSED), return a http 500 to the consumer instead of silently dropping the request.Not sure if this is a bug or a feature..
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).