Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(less): handles rewriting relative paths passed Less's data-uri function. #7400

Merged
merged 3 commits into from Apr 5, 2022
Merged

fix(less): handles rewriting relative paths passed Less's data-uri function. #7400

merged 3 commits into from Apr 5, 2022

Conversation

bbotto-pdga
Copy link
Contributor

@bbotto-pdga bbotto-pdga commented Mar 21, 2022 •
edited by Niputi

Description

Adds support for rewriting relative images paths passed to Less's data-uri function.
close: #7375.

Additional context

This is my first contribution to Vite. I tried to follow the conventions and whatnot, but may have missed something. In particular, it may be worthwhile to update UrlRewritePostcssPlugin, but that's not something I tackled.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi changed the title fix #7375: handles rewriting relative paths passed Less's data-uri function. fix(css): handles rewriting relative paths passed Less's data-uri function. Mar 21, 2022
@Niputi Niputi changed the title fix(css): handles rewriting relative paths passed Less's data-uri function. fix(less): handles rewriting relative paths passed Less's data-uri function. Mar 21, 2022
@Niputi Niputi added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 21, 2022
patak-dev
patak-dev approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good step to me 👍🏼

sapphi-red
sapphi-red approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too 👍

@patak-dev patak-dev merged commit 08e39b7 into vitejs:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative paths passed to Less's data-uri function are not resolved
6 participants
@bbotto-pdga @patak-dev @bluwy @sapphi-red @Niputi @benbotto