Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolve): skip module field when the importer is a require call #7438

Merged
merged 1 commit into from Mar 24, 2022
Merged

fix(resolve): skip module field when the importer is a require call #7438

merged 1 commit into from Mar 24, 2022

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Mar 24, 2022

Description

Fixes #7053

Additional context

I used a require-pkg-with-module-field package in the test, instead of
json-bigint, because I need to pin the bignumber.js version to 9.0.2
in case it changed its package.json in future releases.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sodatea
fix(resolve): skip module field when the importer is a require call
87412a2 
Fixes vitejs#7053

I used a `require-pkg-with-module-field` package in the test, instead of
`json-bigint`, because I need to pin the `bignumber.js` version to 9.0.2
in case it changed its `package.json` in future releases.
@sodatea sodatea added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 24, 2022
@patak-dev patak-dev merged commit fe4c1ed into vitejs:main Mar 24, 2022
@sapphi-red sapphi-red mentioned this pull request Mar 29, 2022
Open
7 tasks
@SteveALee SteveALee mentioned this pull request Apr 2, 2022
Open
7 tasks
@sodatea sodatea mentioned this pull request Apr 2, 2022
Merged
9 tasks
@sapphi-red sapphi-red mentioned this pull request Apr 16, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
2 participants
@sodatea @patak-dev