fix: sourcemap missing source files warning with cached vue #7442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7432
fixes
Sourcemap for "something.vue" points to missing source files
which will happen with vue (and potentially with others)Additional context
vue/compiler-sfc
caches the parse result.https://github.com/vuejs/core/blob/1070f127a78bfe7da6fe550cc272ef11a1f434a0/packages/compiler-sfc/src/parse.ts#L107-L110
Here the parse result is pass directly without cloning.
vite/packages/plugin-vue/src/index.ts
Lines 177 to 194 in 47668b5
And then
combineSourcemaps
will be called somewhere and it will mutate the parse result.So when calling parse second time, the parse result is mutated by
combineSourcemaps
and will not match the result on first time.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).