Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import.meta.url in worker #7464

Merged
merged 4 commits into from Mar 27, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Mar 26, 2022

Description

fix: #4646

Additional context

I think the web worker must have a location. so use the import.meta.url have the same with self.location.href. and don't need to polyfill import.meta.url with rollup.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Mar 26, 2022
@patak-dev
Copy link
Member

LGTM. @poyoho do we have a test case for a nested worker using import.meta.url?

@poyoho poyoho requested a review from patak-dev March 27, 2022 03:16
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: web workers labels Mar 27, 2022
@patak-dev patak-dev merged commit 8ac4b12 into vitejs:main Mar 27, 2022
@poyoho poyoho deleted the fix/worker-import.meta.url branch March 27, 2022 07:52
@bluwy bluwy mentioned this pull request Mar 29, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use import.meta in worker got error: document is not defined
3 participants