refactor(types): share hot context type #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
commented
Mar 26, 2022
| disposeMap.set(ownerPath, cb) | ||
| }, | ||
|
|
||
| // @ts-expect-error untyped | ||
| prune(cb: (data: any) => void) { |
There was a problem hiding this comment.
This is not typed in import.meta.hot - IIRC Svelte is using it - Should we add the type for it?
9 tasks
patak-dev
approved these changes
Mar 26, 2022
This was referenced Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So we can be type-safe for client.ts (also found some misalignment along the way)
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).