Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom event payload type #7498

Merged
merged 1 commit into from Mar 28, 2022
Merged

Conversation

patak-dev
Copy link
Member

Description

Fix VitePress.

Looks like https://github.com/vitejs/vite/pull/7476/files#diff-5bc77abd0513da66cf1ce3d8c50e8108daf0c149a5f5f973eeea3c9d4a47bffbR16 broke VitePress.

See vite-ecosystem-ci run https://github.com/vitejs/vite-ecosystem-ci/runs/5714794922?check_suite_focus=true#step:6:384.

Better message when running locally:

> vitepress@0.22.3 build-client /Users/patak/vitepress
> tsc -p src/client && node scripts/copyClient

src/client/app/index.ts:134:29 - error TS2571: Object is of type 'unknown'.

134         router.route.data = payload.pageData
                                ~~~~~~~
Found 1 error.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev merged commit 28b0660 into main Mar 28, 2022
@patak-dev patak-dev deleted the fix/custom-event-payload-type branch March 28, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants