Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow port 0 to be provided to server #7530

Merged
merged 1 commit into from Mar 31, 2022

Conversation

ahtcx
Copy link
Contributor

@ahtcx ahtcx commented Mar 30, 2022

Description

Allows providing port 0 to the Vite server. Fixes #7529.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ahtcx ahtcx changed the title fix: allow port 0 to be provided to server (#7529) allow port 0 to be provided to server Mar 30, 2022
@ahtcx ahtcx changed the title allow port 0 to be provided to server fix: allow port 0 to be provided to server Mar 30, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we could actually test in CI using port 0. I think the fix looks good as is.

@antfu antfu merged commit 173e4c9 into vitejs:main Mar 31, 2022
@ahtcx ahtcx deleted the fix/allow-port-0-for-server branch April 1, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server won't run with port 0 (assigns any available port)
4 participants