Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): skip known ESM entries when resolving a require call #7582

Merged
merged 4 commits into from Apr 2, 2022

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Apr 2, 2022

Fixes #7578

Additional context

The name of #7438 test case wasn't accurate enough so I changed it in this PR.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

I think this PR will also fix #7376.

'es2015',
'es2020',
'fesm2015',
'fesm2020'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add esm and module-browser because I can't find any real-world use cases of them.
esnext is used by foundation-sites, es20** and fesm20** are used by Angular CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module field breaking CommonJS resolution
3 participants