fix: use correct proxy config in preview #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p3-minor-bug
patak-dev
approved these changes
Apr 4, 2022
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7414
Supersedes #7415
Use the preview proxy config in preview server
Additional context
I only noticed #7415 was created after I finished this 馃槵 But I think this method is a bit more robust. Thanks to @Jinjiang for the pointers in the issue, and @LIUYANG132315 for the initial work.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).