Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ws types #7605

Merged
merged 1 commit into from Apr 4, 2022
Merged

fix: update ws types #7605

merged 1 commit into from Apr 4, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 4, 2022

Description

Fixes #7598

Additional context

Issue introduced in #7437, where the ws types was used in the public types. The public types should use from types/ws instead.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 4, 2022
@bluwy bluwy requested a review from antfu April 4, 2022 02:46
@patak-dev patak-dev merged commit b620587 into vitejs:main Apr 4, 2022
@bluwy bluwy deleted the fix-ws-types branch April 4, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot find module 'ws'" for tsc with skipLibCheck disabled
3 participants