Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EACCES permission denied due to resolve new paths default #7612

Merged
merged 1 commit into from Apr 5, 2022

Conversation

bbbboom
Copy link
Contributor

@bbbboom bbbboom commented Apr 4, 2022

Description

Compatible with changes made by the new version of upstream component "resolve".

Fix #6767.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Compatible with changes made by the new version of upstream component "resolve".
@patak-dev patak-dev changed the title fix EACCES: permission denied, stat '/root/.node_modules/plugin-vue:export-helper' fix: EACCES permission denied due to resolve new paths default Apr 4, 2022
@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 4, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL browserify/resolve#163 (comment)

This LGTM, I think given how many people have reported issues (see activity in #6767) with the new default of paths looking into .node_modules, it is safer to get back to the previous behavior.

At least we should change it when we get a real issue that justifies it. We may also want to backport this fix to 2.7 and 2.8, after testing it for a while in 2.9.

@patak-dev patak-dev requested a review from bluwy April 4, 2022 19:24
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild. TIL too.

@Evertvdw
Copy link

When will the new release be that includes this PR? This is a blocking issue for me as I can't deploy my Vite app to Azure static web apps at the moment due to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
4 participants