Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: esbuild handles target and useDefineForClassFields #7698

Merged
merged 1 commit into from Apr 12, 2022

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Apr 12, 2022

esbuild has added the corresponding handling logic in 0.14.0 and 0.14.35:

So our workaround is no longer needed.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

…s` logic

esbuild has added the corresponding handling logic in 0.14.0 and 0.14.35:
- https://github.com/evanw/esbuild/releases/tag/v0.14.0
- https://github.com/evanw/esbuild/releases/tag/v0.14.35

So our workaround is no longer needed.
@patak-dev patak-dev changed the title refactor: let esbuild handle the target and useDefineForClassFields logic refactor: esbuild handles target and useDefineForClassFields Apr 12, 2022
@patak-dev patak-dev merged commit 0c928aa into vitejs:main Apr 12, 2022
patak-dev added a commit that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants