Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): rewrite dynamic class method name (fix #7751) #7757

Merged
merged 1 commit into from Apr 15, 2022

Conversation

sapphi-red
Copy link
Member

Description

Fix #7751
Fix vitest-dev/vitest#1155

import { value } from "./const";

describe("test class", () => {
  it("test class", () => {
    console.log("value", value); // this `value` wrote correctly
    class A {
      [value]() {} // this `value` was not rewritten
    }
  });
});

Additional context

Related code of vue/compiler-core: https://github.com/vuejs/core/blob/74d2a76af6e830af5abb8aac8484dc1b3e90a510/packages/compiler-core/src/babelUtils.ts#L288-L297


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) and removed p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) p3-minor-bug An edge case that only affects very specific usage (priority) labels Apr 15, 2022
@patak-dev patak-dev merged commit b89974a into vitejs:main Apr 15, 2022
@sapphi-red sapphi-red deleted the fix/ssr-dynamic-class-method-name branch April 29, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import calss filed name throw ReferenceError import calss filed name throw ReferenceError
2 participants