Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modulepreload polyfill only during build (fix #4786) #7816

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 19, 2022

Description

I changed the content of vite/modulepreload-polyfill to '' not during dev.
This will fix #4786.

I think this change can be justified for the following reason.

  • polyfill is not necessary during dev
    • also even if this polyfill is not included and modulepreload is not supported, the code works unlike other polyfills
  • the current polyfill includes __VITE_IS_MODERN__ and it only works during build
    • it can be solved by avoiding this by replacing this even not during build, but I don't think it is needed

fixes #4786
close #6507

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Apr 20, 2022
@patak-dev patak-dev changed the title fix: return modulepreload polyfill only during build (fix #4786) fix: modulepreload polyfill only during build (fix #4786) Apr 20, 2022
@patak-dev patak-dev merged commit 709776f into vitejs:main Apr 20, 2022
@sapphi-red sapphi-red deleted the fix/include-modulepreload-polyfill-error branch April 20, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when manually including vite/modulepreload-polyfill
4 participants