Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape character in string regexp match #7834

Merged
merged 2 commits into from Apr 20, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Apr 20, 2022

Description

escape character in string regexp match.

https://regex101.com/r/fe286c/1

"1\"1"

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 20, 2022
@poyoho poyoho changed the title fix: clean string edge case fix: escape character in string regexp match Apr 20, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-dev patak-dev merged commit 1d468c8 into vitejs:main Apr 20, 2022
@poyoho poyoho deleted the fix/cleanString-edgecase branch April 21, 2022 03:12
kherock pushed a commit to kherock/vite that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants