Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: server.origin config trailing slash (fix #6622) #7865

Merged

Conversation

sapphi-red
Copy link
Member

Description

server.orgin does not work when it ends with /.
This PR fixes document and adds a warning about it.

close #6622

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title docs: server.origin config trailing slash docs: server.origin config trailing slash (fix #6622) Apr 22, 2022
@@ -727,6 +731,18 @@ export function resolveServerOptions(
allow: allowDirs,
deny
}

if (server.origin?.endsWith('/')) {
server.origin = server.origin.slice(0, -1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this line should be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to have it 👍

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Apr 22, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patak-dev patak-dev merged commit 5c1ee5a into vitejs:main Apr 27, 2022
@sapphi-red sapphi-red deleted the docs/config-server-origin-trailing-slash branch April 27, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested font imports 404ing in Vite 2.7.x when a server.origin is set
3 participants