fix: clean string regexp

[poyoho]

Description

fix: #7855

Additional context

make cleanString don't affect by regexp
https://regex101.com/r/G2SYip/1

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[kherock]

This still needs to handle comments that are on the same line as a regexp:

const foo = /'/ // this doesn't work

result:

const foo = this doesn't work

[poyoho]

thank again, fixed! https://regex101.com/r/9myfsm/1

[kherock]

It doesn't seem to work right when there's an escaped \/ within the regex:

https://regex101.com/r/I3tD8q/1

The following seems to work better for me:

"([^"]|(?<=\\)")*"|'([^']|(?<=\\)')*'|\/\*(.|[\r\n])*?\*\/|\/\/.*|\/.*?(?<!\\)\/

[poyoho]

I found, hhh. And fixing now.

[kherock]

Actually yours was just one character off, you had \\ instead of \/ at the end, this works

"([^"]|(?<=\\)")*"|'([^']|(?<=\\)')*'|\/\*(.|[\r\n])*?\*\/|\/\/.*|\/([^\/]|(?<=\\)\/)*\/

[kherock]

I was able to verify that my site is now able to build with these changes, thank you 👍

[poyoho]

https://regex101.com/r/Kk2cJ0/1

I think the best way is make the affect in one line. beacause we can't to process

1 / 1 + new URL('./hello.js', import.meta.url).href + 1 / 1

And I think an error match in one line (such as the below error) can accept.

const a = /111'111/ // new URL('./hello.js', import.meta.url).href 

[kherock]

I was able to catch more cases by ignoring syntactically invalid quote characters. I think this is as good as we can make it without doing a separate initial pass that strips away comments.

https://regex101.com/r/acTUGD/1

The opening quote character is ignored when the most recent non-whitespace character is a word character: (?<=(?:^|[^\w\s])\s*).

Additionally, the closing quote character is ignored when the next non-whitespace character is a word character: (?=\s*(?:$|[^\w\s])). This check prevents single " or ' in comments from being interpreted as a closing quote.

[poyoho]

#7871 (comment)

Although it can narrow the scope of the problem, it still feels that it can not completely solve the problem. I want to solve this problem thoroughly through other methods. 🙈

[poyoho]

@kherock if you interesting in this let talk in discord 😊