Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): clean comments before hoist at rules #7924

Merged
merged 2 commits into from Apr 27, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 27, 2022

Description

Fix #7912. Clean /**/ comments in css string before running regex.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Apr 27, 2022
@bluwy bluwy changed the title fix(css): clean before hoist fix(css): clean comments before hoist at rules Apr 27, 2022
@patak-dev patak-dev merged commit e48827f into vitejs:main Apr 27, 2022
@bluwy bluwy deleted the fix-css-clean-hoist branch April 27, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite@2.9.2+ handle css @import which is wrapped in a comment statement
2 participants