Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): dynamic import css in package fetches removed js (fixes #7955, #6823) #7969

Merged
merged 4 commits into from May 1, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 30, 2022

Description

fixes #7955
fixes #6823
close #6829

related previously merged PR: #3333

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Apr 30, 2022
@sapphi-red
Copy link
Member Author

sapphi-red commented Apr 30, 2022

Oh I forgot to check #6829 before creating this PR. 🤦‍♂️
This PR supersedes it. (my PR includes a test that one does not)

@sapphi-red sapphi-red changed the title fix(css): dynamic import css in package fetches removed js (fixes #7955) fix(css): dynamic import css in package fetches removed js (fixes #7955, #6823) Apr 30, 2022
@patak-dev patak-dev merged commit 025eebf into vitejs:main May 1, 2022
@sapphi-red sapphi-red deleted the fix/css-dynamic-import-in-dep branch May 2, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
3 participants