Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cjs): build cjs for loadEnv #8305

Merged
merged 3 commits into from May 24, 2022
Merged

fix(cjs): build cjs for loadEnv #8305

merged 3 commits into from May 24, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented May 24, 2022

loadEnv was missing in CJS build by #8178

Shinigami92
Shinigami92 previously requested changes May 24, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Seems packages/vite/src/node/__tests__/config.spec.ts needs to be updated

@Shinigami92 Shinigami92 mentioned this pull request May 24, 2022
Merged
9 tasks
@antfu antfu merged commit 80dd2df into main May 24, 2022
@antfu antfu deleted the fix/cjs-load-env branch May 24, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antfu @Shinigami92 @bluwy