Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSR and transformIndexHtml examples and documentation #8318

Closed
4 tasks done
benmccann opened this issue May 25, 2022 · 1 comment · Fixed by #9048
Closed
4 tasks done

Update SSR and transformIndexHtml examples and documentation #8318

benmccann opened this issue May 25, 2022 · 1 comment · Fixed by #9048
Labels
documentation Improvements or additions to documentation enhancement: pending triage
Milestone

Comments

@benmccann
Copy link
Collaborator

Clear and concise description of the problem

The SSR examples in playground don't set spa: false nor does the SSR documentation demonstrate it

transformIndexHtml is not called when spa: false. It's not very useful as a build hook most of the time in SSR apps because the page contents aren't generated until SSR at runtime

Suggested solution

Update docs and examples

Alternative

No response

Additional context

spa: false was added in #7665

Validations

@benmccann benmccann added documentation Improvements or additions to documentation enhancement: pending triage labels May 25, 2022
@benmccann benmccann added this to the 3.0 milestone May 25, 2022
@benmccann
Copy link
Collaborator Author

This may change as the result of #8452

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement: pending triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant