Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode _ and . in different way #8508

Merged
merged 3 commits into from Jun 9, 2022

Conversation

stygian-desolator
Copy link
Contributor

Description

close #8428

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stygian-desolator stygian-desolator changed the title fix: encode id in different way fix: encode _ and . in different way Jun 8, 2022
@patak-dev
Copy link
Member

@bluwy since you changed this in both:

Is there a reason to only use _ when flattening the ids? It seems a bit strange to be coding , :, and . to _, __, and ___. Could other symbols be safely used? I imagine that - isn't used to avoid colliding with package names.

@bluwy
Copy link
Member

bluwy commented Jun 9, 2022

Is there a reason to only use _ when flattening the ids? It seems a bit strange to be coding , :, and . to _, __, and ___. Could other symbols be safely used? I imagine that - isn't used to avoid colliding with package names.

I don't think there's a particular reason other than it being easy to read when viewing the directory. As long as the symbol can be used in a filename and URL it should be usable, though there doesn't seem to be a cleaner one than _

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@patak-dev patak-dev enabled auto-merge (squash) June 9, 2022 15:29
@patak-dev patak-dev disabled auto-merge June 9, 2022 15:29
@patak-dev patak-dev merged commit 9065b37 into vitejs:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lodash/cloneDeep and lodash.clonedeep: Two output files share the same path but have different contents.
3 participants