Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: type client maps #8626

Merged
merged 3 commits into from Jun 20, 2022
Merged

refactor: type client maps #8626

merged 3 commits into from Jun 20, 2022

Conversation

sapphi-red
Copy link
Member

Description

  • Add stricter types to src/client/client.ts.
  • Update docs to be more accurate

refs #8625

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Jun 17, 2022
@patak-dev patak-dev merged commit cf87882 into vitejs:main Jun 20, 2022
@sapphi-red sapphi-red deleted the refactor/type-client-maps branch June 20, 2022 07:15
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 21, 2022
@sapphi-red
docs: add vitejs#8626 to migration guide
36289e4
@sapphi-red sapphi-red mentioned this pull request Jun 21, 2022
Merged
9 tasks
patak-dev pushed a commit that referenced this pull request Jun 21, 2022
@sapphi-red
docs: add #8626 to migration guide (#8698)
3f9e5d4
@sapphi-red sapphi-red mentioned this pull request Jul 9, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sapphi-red @bluwy @patak-dev