perf(lib): improve helper inject regex #8741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
patak-dev
approved these changes
Jun 23, 2022
chrispcampbell
added a commit
to climateinteractive/SDEverywhere
that referenced
this pull request
Jun 28, 2022
This avoids a performance regression that is reproducible when using vite 2.9.x versions >= 2.9.7. It seems to have been fixed in 3.0.0 beta, see: vitejs/vite#8741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves perf of helper inject regex.
umd bench
iife bench
close #8738
close #8517
refs #7948
refs #8110
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).