Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always remove temp config #8782

Merged
merged 1 commit into from Jun 25, 2022

Conversation

sapphi-red
Copy link
Member

Description

A temporary file which contains bundled config result was not removed when an error happened during dynamic importing that.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 25, 2022
@netlify
Copy link

netlify bot commented Jun 25, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 06593a7
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b7062b801a5500085287b9
😎 Deploy Preview https://deploy-preview-8782--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev merged commit 2c2a86b into vitejs:main Jun 25, 2022
@sapphi-red sapphi-red deleted the fix/always-remove-temp-config branch June 25, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants