perf: avoid sourcemap chains during dev #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main canceled.
|
poyoho
reviewed
Jun 26, 2022
sapphi-red
added
the
p4-important
poyoho
force-pushed
the
fix/dev-sourcemap-generation
branch
from
6d8cf6f
to
1596f42
Compare
poyoho
previously approved these changes
Jun 26, 2022
patak-dev
commented
Jun 26, 2022
patak-dev
commented
Jun 26, 2022
poyoho
previously approved these changes
Jun 26, 2022
patak-dev
commented
Jun 26, 2022
poyoho
approved these changes
Jun 26, 2022
sapphi-red
approved these changes
Jun 26, 2022
bluwy
approved these changes
Jun 26, 2022
patak-dev
changed the title
|
For reference: the idea is that Vite takes care of keeping the line structure of sources during the transpilation by different plugins stable. By doing so, it isn't necessary to do a chain of source maps, with a new one on each plugin. Some affected lines may end up with the column mapping for a given line wrong, but it is a fair price to pay for having the dev server run twice as fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a perf regression @yyx990803 found introduced by:
Internal Plugins using
transformStableResultneeds to avoid modifying the line structure of the code, as sourcemaps generation during dev is skipped.What is the purpose of this pull request?