fix: incorrectly resolving knownJsSrcRE files from root (fixes #4161)
#8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
bug
p3-downstream-blocker
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sapphi-red
commented
Jun 27, 2022
Comment on lines
-175
to
+176
| (preferRelative && /^\w/.test(id)) || | ||
| importer?.endsWith('.html') | ||
| ((preferRelative || importer?.endsWith('.html')) && /^\w/.test(id)) |
There was a problem hiding this comment.
I think this was incorrect. If importer is html it was always handled as relative path.
So /foo.svelte will be resolved to
const basedir = importer ? path.dirname(importer) : process.cwd() // C:\Users\green\workspace
const fsPath = path.resolve(basedir, id) // C:\foo.svelte
const normalizedFsPath = normalizePath(fsPath) // C:/foo.svelte
Comment on lines
+242
to
+245
| if ( | ||
| isNonDriveRelativeAbsolutePath(id) && | ||
| (res = tryFsResolve(id, options)) | ||
| ) { |
There was a problem hiding this comment.
Even if the condition above is fixed, this is still needed.
/foo.svelte will be handled as C:/foo.svelte inside tryFsResolve by fs.statSync and others.
patak-dev
reviewed
Jun 27, 2022
patak-dev
approved these changes
Jun 28, 2022
9 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
path.isAbsolutereturn true for/somethingalso on windows.https://nodejs.org/api/path.html#pathisabsolutepath
If the working directory is
C:\Users\green,/somethingmeansC:\something.fixes #4161
refs #8122
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).