Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move basic ssl setup to external plugin, fix #8532 #8961

Merged
merged 4 commits into from Jul 7, 2022

Conversation

patak-dev
Copy link
Member

Description

See for context:


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 12a02e5
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c6d3fd5d0b3a00076c198c
😎 Deploy Preview https://deploy-preview-8961--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should document this in the migration guide too. Also I found https://github.com/liuweiGL/vite-plugin-mkcert which looks similar to @vitejs/plugin-basic-ssl 👀

README.md Outdated
| [@vitejs/plugin-vue-jsx](packages/plugin-vue-jsx) | [![plugin-vue-jsx version](https://img.shields.io/npm/v/@vitejs/plugin-vue-jsx.svg?label=%20)](packages/plugin-vue-jsx/CHANGELOG.md) |
| [@vitejs/plugin-react](packages/plugin-react) | [![plugin-react version](https://img.shields.io/npm/v/@vitejs/plugin-react.svg?label=%20)](packages/plugin-react/CHANGELOG.md) |
| [@vitejs/plugin-legacy](packages/plugin-legacy) | [![plugin-legacy version](https://img.shields.io/npm/v/@vitejs/plugin-legacy.svg?label=%20)](packages/plugin-legacy/CHANGELOG.md) |
| [@vitejs/plugin-basic-ssl](https://github.com/vitejs/vite-plugin-basic-ssl) | [![plugin-legacy version](https://img.shields.io/npm/v/@vitejs/plugin-basic-ssl.svg?label=%20)](https://github.com/vitejs/vite-plugin-basic-ssl/CHANGELOG.md) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be confusing to show this here given it's not part of the monorepo, and something we discourage as we want users to make a real cert 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is true. I'll remove it from here, and only keep it in the migration guide.
About vite-plugin-mkcert that looks a lot better. I don't know enough about the project to recommend it here. But I think someone should at some point do a PR to update the docs with recommendations.

@patak-dev patak-dev added the p3-significant High priority enhancement (priority) label Jul 7, 2022
@patak-dev patak-dev added this to the 3.0 milestone Jul 7, 2022
@patak-dev patak-dev changed the title refactor: move basic ssl setup to external plugin, fix #8532 refactor!: move basic ssl setup to external plugin, fix #8532 Jul 7, 2022
@patak-dev patak-dev merged commit 5c6cf5a into main Jul 7, 2022
@patak-dev patak-dev deleted the feat/plugin-basic-ssl branch July 7, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants