fix(ssr): fix sourcemap content (fixes #8657) #8997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
has workaround
p3-downstream-blocker
✅ Deploy Preview for vite-docs-main canceled.
|
sapphi-red
commented
Jul 8, 2022
Comment on lines
305
to
+315
| test('sourcemap source', async () => { | ||
| expect( | ||
| (await ssrTransform(`export const a = 1`, null, 'input.js')).map.sources | ||
| ).toStrictEqual(['input.js']) | ||
| const map = ( | ||
| await ssrTransform( | ||
| `export const a = 1`, | ||
| null, | ||
| 'input.js', | ||
| 'export const a = 1 /* */' | ||
| ) | ||
| )?.map | ||
| expect(map?.sources).toStrictEqual(['input.js']) | ||
| expect(map?.sourcesContent).toStrictEqual(['export const a = 1 /* */']) |
There was a problem hiding this comment.
Changes in this file except this change is just a refactor.
| @@ -258,7 +259,7 @@ async function loadAndTransform( | |||
| } | |||
|
|
|||
| const result = ssr | |||
| ? await ssrTransform(code, map as SourceMap, url, { | |||
| ? await ssrTransform(code, map as SourceMap, url, originalCode, { | |||
There was a problem hiding this comment.
Instead of passing originalCode, we could always generate sourcemaps. But that will cost a lot if the file is large.
bluwy
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For js,
sourcemapContentwas including the transformed content.For ts,
sourcemapContentwas not included.fixes #8657
Additional context
I'm not sure if this is the best approach.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).