Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): allow virtual paths on node modules #9405

Merged
merged 1 commit into from Jul 29, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 28, 2022

Description

fix #9364

Additional context

Catch errors from tryNodeResolve and no externalize if an error is caught so we process it through Vite.

Maybe also worth discussing whether we want to support #9364


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit afraid of this making bugs in this branch harder to triage later, but I don't see a way out of having this try/catch guard at this point.

@bluwy
Copy link
Member Author

bluwy commented Jul 28, 2022

Perhaps we can add a debug log for edge cases like this? Since we cache the result, I don't think it would be noisy.

@patak-dev
Copy link
Member

Perhaps we can add a debug log for edge cases like this? Since we cache the result, I don't think it would be noisy.

Yes, I think a debug log is a good idea 👍🏼

@patak-dev
Copy link
Member

I'll merge this one so we can cut a release. Let's add the debug message in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolveId is not respected by SSR externalizer
2 participants