Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): use file url for import path (fixes #9471) #9473

Merged
merged 1 commit into from Aug 1, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 31, 2022

Description

I tested this PR with #9471.
Actually #9471 needs to change import { libConfig } from "../vite-config" into import { libConfig } from "../vite-config/index.js" because ESM doesn't support dir imports.

fixes #9471

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added bug windows only p3-minor-bug An edge case that only affects very specific usage (priority) labels Jul 31, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just making this PR 🙃

@bluwy bluwy merged commit 22084a6 into vitejs:main Aug 1, 2022
@sapphi-red sapphi-red deleted the fix/config-import-external-windows branch August 1, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) windows only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import files into vite.config.ts on Windows with "type": "module" in package.json
2 participants