Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): don't use file url for external files with cjs output #9642

Merged
merged 1 commit into from Aug 12, 2022
Merged

fix(config): don't use file url for external files with cjs output #9642

merged 1 commit into from Aug 12, 2022

Conversation

ArnaudBarre
Copy link
Member

Description

#9473 fixed the ability to import a file in a monorepo for esm but broke it for cjs.

Not sure this is the best fix though.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red linked an issue Aug 11, 2022 that may be closed by this pull request
Cannot find module 'file://xxx' when vite.config.ts import absolute path #9617
Closed
7 tasks
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Aug 11, 2022
sapphi-red
sapphi-red approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red changed the title fix(config): Don't use file url for external files with cjs output fix(config): don't use file url for external files with cjs output Aug 11, 2022
@patak-dev patak-dev merged commit 73ad707 into vitejs:main Aug 12, 2022
@ArnaudBarre ArnaudBarre deleted the fix-config-cjs branch August 12, 2022 08:19
@ImRodry ImRodry mentioned this pull request Aug 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module 'file://xxx' when vite.config.ts import absolute path
3 participants
@ArnaudBarre @sapphi-red @patak-dev