Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr-manifest): filter path undefined when dynamic import #9655

Merged
merged 1 commit into from Aug 15, 2022
Merged

fix(ssr-manifest): filter path undefined when dynamic import #9655

merged 1 commit into from Aug 15, 2022

Conversation

jambonn
Copy link
Contributor

@jambonn jambonn commented Aug 13, 2022

Description

PR fix ssr-manifest plugin for v3. v2 has been merged at PR #9595

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@jambonn
Copy link
Contributor Author

jambonn commented Aug 13, 2022

@bluwy Hope you can approve to help me. Thank you!

@bluwy bluwy merged commit 1478a2f into vitejs:main Aug 15, 2022
@jambonn jambonn deleted the fix-ssr-manifest branch August 15, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jambonn @bluwy