fix(hmr): duplicate link tags #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p3-minor-bug
sapphi-red
reviewed
Aug 16, 2022
packages/vite/src/client/client.ts
Outdated
| @@ -126,6 +126,7 @@ function cleanUrl(pathname: string): string { | |||
| } | |||
|
|
|||
| let isFirstUpdate = true | |||
| const invalidLinkTags = new Set<HTMLLinkElement>() | |||
There was a problem hiding this comment.
Maybe we could use WeakSet to be safe?
There was a problem hiding this comment.
Hmm..., I'm not sure about the client code's browser support
There was a problem hiding this comment.
We are transpiling client code to es2019. So I believe it's fine.
|
It's easier to reproduce in my recent development, so I created this PR ~ |
sapphi-red
changed the title
sapphi-red
approved these changes
Aug 16, 2022
patak-dev
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: duplicate link tags will be generated when the style file is edited and saved too frequently.
The bug occurred when a new message push was received before the
newLinkTagcallback responded.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).