Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update import.meta.glob jsdocs #9709

Merged
merged 2 commits into from Aug 16, 2022
Merged

docs: update import.meta.glob jsdocs #9709

merged 2 commits into from Aug 16, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 16, 2022

Description

Close #9599

Additional context

I think #9599 is mostly a usage issue between v2 and v3, but I've updated the jsdoc as the 2. and 3. are rendered as 1. in vscode, and the text doesn't quite make sense without context.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the documentation Improvements or additions to documentation label Aug 16, 2022
antfu
antfu previously approved these changes Aug 16, 2022
@patak-dev patak-dev enabled auto-merge (squash) August 16, 2022 15:53
@patak-dev patak-dev merged commit 15ff3a2 into main Aug 16, 2022
@patak-dev patak-dev deleted the docs-import-glob branch August 16, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Document type inference with import.meta.glob
3 participants