Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): warn if cant analyze dynamic import #9738

Merged
merged 1 commit into from Aug 19, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 18, 2022

Description

If SSR contains a dynamic import that can't be analyzed, warn about it. (similar to client)

Also only warn if the file we're analyzing is not in node_modules, since the user likely can't do anything except patching. (Could hide potential problems but maybe the cases are rare 馃 )

Ref withastro/astro#3373 (comment)

Additional context

Happy to discuss each changes, maybe I'm missing some important aspects.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels Aug 18, 2022
@patak-dev patak-dev merged commit e0ecb80 into main Aug 19, 2022
@patak-dev patak-dev deleted the warn-unknown-import-ssr branch August 19, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants