fix: injectQuery break relative path
#9760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poyoho
added
feat: web workers
p3-minor-bug
bluwy
previously approved these changes
Aug 19, 2022
sapphi-red
reviewed
Aug 20, 2022
sapphi-red
reviewed
Aug 20, 2022
sapphi-red
reviewed
Aug 20, 2022
Comment on lines
16
to
20
| test('normalize windows path', () => { | ||
| expect(injectQuery('C:\\User\\Vite\\Project', 'direct')).toEqual( | ||
| 'C:/User/Vite/Project?direct' | ||
| 'C:\\User\\Vite\\Project?direct' | ||
| ) | ||
| }) |
There was a problem hiding this comment.
It can to exec normalizePath it will reducing '..' and '.' parts. But now it will lose When multiple slashes are found, they're replaced by a single one; when the path contains a trailing slash, it is preserved. On Windows backslashes are used. this feature.
patak-dev
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #9525
Additional context
injectQuery break the relative path. if url[0] is not '/' should be relative path, should
.slice(1)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).