refactor(hmr): simplify fetchUpdate #9881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
force-pushed
the
refactor/hmr-fetch-update
branch
from
2f3b3d4
to
32f3168
Compare
sapphi-red
commented
Aug 28, 2022
Comment on lines
-404
to
-417
| const modulesToUpdate = new Set<string>() | ||
| if (isSelfUpdate) { | ||
| // self update - only update self | ||
| modulesToUpdate.add(path) | ||
| } else { | ||
| // dep update | ||
| for (const { deps } of mod.callbacks) { | ||
| deps.forEach((dep) => { | ||
| if (acceptedPath === dep) { | ||
| modulesToUpdate.add(dep) | ||
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
modulesToUpdate was always new Set([]) or new Set([acceptedPath]).
Because:
- in
if (isSelfUpdate)blockpath === acceptedPathistrueso it's callingmodulesToUpdate.add(acceptedPath)
- in
elseblock- it's only calling
modulesToUpdate.add(dep)whenacceptedPath === dep. So it's callingmodulesToUpdate.add(acceptedPath).
- it's only calling
|
For review, it might be easier to see each commit, because I made each commit equivalent before and after the change. |
patak-dev
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks for the step-by-step commits @sapphi-red, that helped a lot!
Some historic bits for reference, the current implementation needed the Set when it was first created. It was first changed here, and then again here. After that second change, this part of the codebase remained untouched.
|
Just read through the commits, and it's beautiful. Reminds me of the days we do equation simplification in math classes 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
fetchUpdatefunction inclient/client.ts.Splitted from #9773.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).