feat(css): format error #9909
Merged
feat(css): format error #9909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: css
p2-nice-to-have
sapphi-red
commented
Aug 30, 2022
| }) | ||
| test('empty line', () => { | ||
| const actual = posToNumber('a\n\nb', { line: 3, column: 0 }) | ||
| expect(actual).toBe(3) |
There was a problem hiding this comment.
This was returning 2.
patak-dev
reviewed
Aug 30, 2022
Comment on lines
-437
to
-439
| if (lines[i]) { | ||
| start += lines[i].length + 1 | ||
| } |
There was a problem hiding this comment.
This condition was added because of a reported issue #5647 (comment). But it looks like this guard isn't correct, if lines[i] is '' then a +1 is needed here.
patak-dev
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add information where the error came from.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).