From 83a63ad4a865c90944723bc51ff5df65dcd8d487 Mon Sep 17 00:00:00 2001 From: patak Date: Sun, 26 Mar 2023 13:52:33 +0200 Subject: [PATCH] perf: avoid fsp.unlink if we don't use the promise --- packages/vite/src/node/config.ts | 6 +----- packages/vite/src/node/optimizer/index.ts | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index e63877c1698f17..31c643fdbe3bdf 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -1092,11 +1092,7 @@ async function loadConfigFromBundledFile( try { return (await dynamicImport(fileUrl)).default } finally { - try { - await fsp.unlink(fileNameTmp) - } catch { - // already removed if this function is called twice simultaneously - } + fs.unlink(fileNameTmp, () => {}) // Ignore errors } } // for cjs, we can register a custom loader via `_require.extensions` diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts index 0c0e90821bde56..4e58cb19c76d47 100644 --- a/packages/vite/src/node/optimizer/index.ts +++ b/packages/vite/src/node/optimizer/index.ts @@ -626,7 +626,7 @@ export function runOptimizeDeps( // Clean up old files in the background for (const filePath of oldFilesPaths) - if (!newFilesPaths.has(filePath)) fsp.unlink(filePath) + if (!newFilesPaths.has(filePath)) fs.unlink(filePath, () => {}) // ignore errors await Promise.all(files) },