From 29021bb897e9c36ee97097c6e6d2f09f2476f6f2 Mon Sep 17 00:00:00 2001 From: Oliver Tsang <517578480@qq.com> Date: Wed, 9 Feb 2022 02:20:43 +0800 Subject: [PATCH 1/2] fix: allow reusing variable names between module scripts in entry html (#6851) --- .../__tests__/optimize-deps.spec.ts | 4 + packages/playground/optimize-deps/index.html | 19 ++++- packages/vite/src/node/optimizer/scan.ts | 77 +++++++++---------- 3 files changed, 55 insertions(+), 45 deletions(-) diff --git a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts index f3ae6e8147b0f4..174dc77c81aaf3 100644 --- a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts +++ b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts @@ -91,3 +91,7 @@ test('import optimize-excluded package that imports optimized-included package', test('import aliased package with colon', async () => { expect(await page.textContent('.url')).toBe('vitejs.dev') }) + +test('variable names are reused in different scripts', async () => { + expect(await page.textContent('.reused-variable-names')).toBe('reused') +}) diff --git a/packages/playground/optimize-deps/index.html b/packages/playground/optimize-deps/index.html index 8451d968d2745b..65b6bf1dcf5473 100644 --- a/packages/playground/optimize-deps/index.html +++ b/packages/playground/optimize-deps/index.html @@ -56,6 +56,15 @@