From 7a848c7918aaad68b3be99c7d073b0736b4c26f5 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Sun, 27 Feb 2022 14:07:54 +0300 Subject: [PATCH 1/3] fix: throw Error when can't preload CSS --- packages/vite/src/node/plugins/importAnalysisBuild.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vite/src/node/plugins/importAnalysisBuild.ts b/packages/vite/src/node/plugins/importAnalysisBuild.ts index bb5b50f93cdbb9..758861793bb6bc 100644 --- a/packages/vite/src/node/plugins/importAnalysisBuild.ts +++ b/packages/vite/src/node/plugins/importAnalysisBuild.ts @@ -75,7 +75,7 @@ function preload(baseModule: () => Promise<{}>, deps?: string[]) { if (isCss) { return new Promise((res, rej) => { link.addEventListener('load', res) - link.addEventListener('error', rej) + link.addEventListener('error', () => rej(new Error(`Unable to load CSS for ${dep}`))) }) } }) From 594fadb0e84f9765279c74841493bffd7c7143b4 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Sun, 27 Feb 2022 14:14:16 +0300 Subject: [PATCH 2/3] chore: linting PR --- packages/vite/src/node/plugins/importAnalysisBuild.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/vite/src/node/plugins/importAnalysisBuild.ts b/packages/vite/src/node/plugins/importAnalysisBuild.ts index 758861793bb6bc..9c2127914f2d2a 100644 --- a/packages/vite/src/node/plugins/importAnalysisBuild.ts +++ b/packages/vite/src/node/plugins/importAnalysisBuild.ts @@ -75,7 +75,9 @@ function preload(baseModule: () => Promise<{}>, deps?: string[]) { if (isCss) { return new Promise((res, rej) => { link.addEventListener('load', res) - link.addEventListener('error', () => rej(new Error(`Unable to load CSS for ${dep}`))) + link.addEventListener('error', () => + rej(new Error(`Unable to load CSS for ${dep}`)) + ) }) } }) From 276fac1870dd66f9c8fd78dcd4f7786b5b7c935f Mon Sep 17 00:00:00 2001 From: Vladimir Date: Tue, 1 Mar 2022 19:36:21 +0300 Subject: [PATCH 3/3] Update packages/vite/src/node/plugins/importAnalysisBuild.ts Co-authored-by: Bjorn Lu --- packages/vite/src/node/plugins/importAnalysisBuild.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vite/src/node/plugins/importAnalysisBuild.ts b/packages/vite/src/node/plugins/importAnalysisBuild.ts index 9c2127914f2d2a..d816d4c1995fd8 100644 --- a/packages/vite/src/node/plugins/importAnalysisBuild.ts +++ b/packages/vite/src/node/plugins/importAnalysisBuild.ts @@ -76,7 +76,7 @@ function preload(baseModule: () => Promise<{}>, deps?: string[]) { return new Promise((res, rej) => { link.addEventListener('load', res) link.addEventListener('error', () => - rej(new Error(`Unable to load CSS for ${dep}`)) + rej(new Error(`Unable to preload CSS for ${dep}`)) ) }) }