-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization won't load in a production build (NextJS) #1536
Comments
*Note that the |
Have you tried the current latest version on NPM (2.0.3)? The published bundles immediately after the major version bump v2.0.0 and 2.0.1 had issues. Also, for debugging purposes, can you try swapping out |
@keller-mark We are currently using version 2.0.3. I just noted during some trial and error that the same error occurred on previous versions that were still version 2. After updating the imports to use
|
I can reproduce locally, it seems to have something to do with AJV (a JSON schema validator package). I have no idea why. I tried pinning a different AJV version in a nextJS app and still encountered the error with Vitessce v2.0.3. Luckily, we have a PR that gets rid of AJV (for different reasons) #1441 so this issue should be fixed in the next Vitessce version. I just tested with a local version of the branch To reproduce locally: # clone vitessce repo
cd vitessce
git checkout keller-mark/file-exts
pnpm install
pnpm run clean
pnpm run build
pnpm run bundle
./scripts/consumer-install.sh
cd ../nextjs-blog
npm install $(ls ../vitessce/consumer/vitessce-*.tgz)
npm run dev
npm run build |
This was my component import dynamic from 'next/dynamic';
const Vitessce = dynamic(() => import('./VitessceWrapper'), {
loading: () => <p>Loading...</p>,
ssr: false,
});
const config = {
// omitted
};
export default function Vis() {
return (
<Vitessce config={config} theme="dark" height={600} />
);
} |
@keller-mark Awesome thank you for all of this information! No rush, as we can and have been using version 1, but do you have any idea on when this PR will make it into production? |
hopefully ASAP! Just need a re-review from another team member |
Describe the bug
We are implementing the lazy load method described here (http://vitessce.io/docs/js-react-vitessce/#lazy-loading), which works in local development but causes the following error when running in production:
Seems to fail regardless of the configuration.
This was not a problem on version 1.2.2.
To Reproduce
npm run build
npm run start
Expected behavior
No warnings in console.
Screenshots
Configuration
Environment:
The text was updated successfully, but these errors were encountered: