Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: PlannedReparentShard should allow cross-cell takeover without requiring tablet alias #15846

Open
arthurschreiber opened this issue May 6, 2024 · 0 comments
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature Request

Comments

@arthurschreiber
Copy link
Contributor

Feature Description

PlannedReparentShard can only perform cross-cell takeovers when a tablet alias in another cell is explicitly passed in via the --new-primary flag.

I'm not sure what the historic reason for this behaviour is, but in our setup, we don't really care whether a planned failover picks a tablet in the same cell or in a different cell.

To support this use-case better, I propose we add a --target-cells option to PlannedReparentShard that allows in passing a list of cells (or cell aliases) from which the primary candidate will be picked. The option can default to the current primary's cell for backwards compatibility.

Use Case(s)

Picking a tablet ourselves and passing it in explicitly from the list of available tablets across all cells is not a good workaround, as it skips the sorting that ensures that the "most up to date" tablet is picked automatically.

@arthurschreiber arthurschreiber added Type: Feature Request Needs Triage This issue needs to be correctly labelled and triaged labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature Request
Projects
None yet
Development

No branches or pull requests

1 participant