fix: improve execution time counter

vitest-dev · Jul 27, 2022 · 0d1f1e8 · 0d1f1e8
1 parent 53157a3
commit 0d1f1e8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/packages/vitest/src/node/reporters/base.ts b/packages/vitest/src/node/reporters/base.ts
@@ -209,7 +209,10 @@ export abstract class BaseReporter implements Reporter {
     }
 
     const executionTime = this.end - this.start
-    const threadTime = files.reduce((acc, test) => acc + Math.max(0, test.result?.duration || 0) + Math.max(0, test.collectDuration || 0), 0)
+    const collectTime = files.reduce((acc, test) => acc + Math.max(0, test.collectDuration || 0), 0)
+    const setupTime = files.reduce((acc, test) => acc + Math.max(0, test.setupDuration || 0), 0)
+    const testsTime = files.reduce((acc, test) => acc + Math.max(0, test.result?.duration || 0), 0)
+    const threadTime = collectTime + testsTime + setupTime
 
     const padTitle = (str: string) => c.dim(`${str.padStart(10)} `)
     const time = (time: number) => {
@@ -232,9 +235,8 @@ export abstract class BaseReporter implements Reporter {
     logger.log(padTitle('Tests'), getStateString(tests))
     if (this.watchFilters)
       logger.log(padTitle('Time'), time(threadTime))
-
     else
-      logger.log(padTitle('Time'), time(executionTime) + c.gray(` (in thread ${time(threadTime)}, ${(executionTime / threadTime * 100).toFixed(2)}%)`))
+      logger.log(padTitle('Time'), time(executionTime) + c.gray(` (setup ${time(setupTime)}, collect ${time(collectTime)}, tests ${time(testsTime)})`))
 
     logger.log()
   }

diff --git a/packages/vitest/src/runtime/collect.ts b/packages/vitest/src/runtime/collect.ts
@@ -47,8 +47,11 @@ export async function collectTests(paths: string[], config: ResolvedConfig) {
 
     clearCollectorContext()
     try {
+      const setupStart = now()
       await runSetupFiles(config)
 
+      const collectStart = now()
+      file.setupDuration = collectStart - setupStart
       if (config.browser && isBrowser)
         await importFromBrowser(filepath)
       else
@@ -66,13 +69,12 @@ export async function collectTests(paths: string[], config: ResolvedConfig) {
           file.tasks.push(c)
         }
         else {
-          const start = now()
           const suite = await c.collect(file)
-          file.collectDuration = now() - start
           if (suite.name || suite.tasks.length)
             file.tasks.push(suite)
         }
       }
+      file.collectDuration = now() - collectStart
     }
     catch (e) {
       file.result = {

diff --git a/packages/vitest/src/types/tasks.ts b/packages/vitest/src/types/tasks.ts
@@ -38,6 +38,7 @@ export interface Suite extends TaskBase {
 export interface File extends Suite {
   filepath: string
   collectDuration?: number
+  setupDuration?: number
 }
 
 export interface Test<ExtraContext = {}> extends TaskBase {