fix(vitest): fix optimizeDeps.disabled warnings on Vite 5.1 (#5215)

Author: hi-ogawa

packages/vitest/src/node/plugins/utils.ts

@@ -13,7 +13,7 @@ export function resolveOptimizerConfig(_testOptions: DepsOptimizationOptions | u
   if (!allowed && testOptions?.enabled === true)
     console.warn(`Vitest: "deps.optimizer" is only available in Vite >= 4.3.2, current Vite version: ${viteVersion}`)
   else
-    // enable by default
+    // disabled by default
     testOptions.enabled ??= false
   if (!allowed || testOptions?.enabled !== true) {
     newConfig.cacheDir = undefined
@@ -50,6 +50,17 @@ export function resolveOptimizerConfig(_testOptions: DepsOptimizationOptions | u
       include,
     }
   }
+
+  // `optimizeDeps.disabled` is deprecated since v5.1.0-beta.1
+  // https://github.com/vitejs/vite/pull/15184
+  if (major >= 5 && minor >= 1) {
+    if (newConfig.optimizeDeps.disabled) {
+      newConfig.optimizeDeps.noDiscovery = true
+      newConfig.optimizeDeps.include = []
+    }
+    delete newConfig.optimizeDeps.disabled
+  }
+
   return newConfig
 }
 

pnpm-lock.yaml

@@ -0,0 +1 @@
+export const importMetaUrl = import.meta.url

test/optimize-deps/dep-url/index.js

@@ -0,0 +1,5 @@
+{
+  "name": "@vitest/test-deps-url",
+  "type": "module",
+  "exports": "./index.js"
+}

test/optimize-deps/dep-url/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "@vitest/test-optimize-deps",
+  "type": "module",
+  "private": true,
+  "scripts": {
+    "test": "vitest"
+  },
+  "devDependencies": {
+    "@vitest/test-dep-url": "file:./dep-url",
+    "vitest": "workspace:*"
+  }
+}

test/optimize-deps/package.json

@@ -0,0 +1,12 @@
+// @vitest-environment node
+
+import { expect, test } from 'vitest'
+
+// @ts-expect-error untyped
+import { importMetaUrl } from '@vitest/test-dep-url'
+
+// TODO: flaky on Windows
+// https://github.com/vitest-dev/vitest/pull/5215#discussion_r1492066033
+test.skipIf(process.platform === 'win32')('import.meta.url', () => {
+  expect(importMetaUrl).toContain('/node_modules/.vitest/deps_ssr/')
+})

test/optimize-deps/test/ssr.test.ts

@@ -0,0 +1,10 @@
+// @vitest-environment happy-dom
+
+import { expect, test } from 'vitest'
+
+// @ts-expect-error untyped
+import { importMetaUrl } from '@vitest/test-dep-url'
+
+test('import.meta.url', () => {
+  expect(importMetaUrl).toContain('/node_modules/.vitest/deps/')
+})

test/optimize-deps/test/web.test.ts

@@ -0,0 +1,40 @@
+import { defineConfig } from 'vitest/config'
+
+export default defineConfig({
+  optimizeDeps: {
+    include: ['@vitest/test-dep-url'],
+  },
+  ssr: {
+    optimizeDeps: {
+      include: ['@vitest/test-dep-url'],
+    },
+  },
+  test: {
+    chaiConfig: {
+      truncateThreshold: 1000,
+    },
+    deps: {
+      optimizer: {
+        web: {
+          enabled: true,
+        },
+        ssr: {
+          enabled: true,
+        },
+      },
+    },
+  },
+  // use dummy ssrLoadModule to trigger ssr.optimizeDeps.
+  // this will be unnecessary from Vite 5.1
+  // cf. https://github.com/vitejs/vite/pull/15561
+  plugins: [
+    {
+      name: 'force-ssr-optimize-deps',
+      configureServer(server) {
+        return async () => {
+          await server.ssrLoadModule('/package.json')
+        }
+      },
+    },
+  ],
+})