fix: resolve node_module mock in npm (#284)

vitest-dev · Dec 28, 2021 · 20e1749 · 20e1749 · 11joselu · Dec 28, 2021
1 parent e474317
commit 20e1749
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/vitest/src/node/execute.ts b/packages/vitest/src/node/execute.ts
@@ -83,6 +83,7 @@ export async function executeInViteNode(options: ExecuteOptions) {
     clearMocks,
     unmockPath,
     resolveMockPath,
+    resolveDependency,
   } = createMocker(root, mockMap)
 
   const result = []
@@ -106,7 +107,7 @@ export async function executeInViteNode(options: ExecuteOptions) {
     const request = async(dep: string, canMock = true) => {
       if (canMock) {
         const mocks = mockMap[suite || ''] || {}
-        const mock = mocks[dep]
+        const mock = mocks[resolveDependency(dep)]
         if (typeof mock === 'function')
           return callFunctionMock(dep, mock)
         if (typeof mock === 'string')

diff --git a/packages/vitest/src/node/mocker.ts b/packages/vitest/src/node/mocker.ts
@@ -1,5 +1,5 @@
 import { existsSync, readdirSync } from 'fs'
-import { basename, dirname, resolve } from 'pathe'
+import { basename, dirname, join, resolve } from 'pathe'
 import { spies, spyOn } from '../integrations/jest-mock'
 import { mergeSlashes } from '../utils'
 
@@ -127,6 +127,14 @@ export function createMocker(root: string, mockMap: SuiteMocks) {
     })
   }
 
+  // npm resolves as /node_modules, but we store as /@fs/.../node_modules
+  function resolveDependency(dep: string) {
+    if (dep.startsWith('/node_modules/'))
+      return mergeSlashes(`/@fs/${join(root, dep)}`)
+
+    return dep
+  }
+
   return {
     mockPath,
     unmockPath,
@@ -136,5 +144,6 @@ export function createMocker(root: string, mockMap: SuiteMocks) {
     mockObject,
     getSuiteFilepath,
     resolveMockPath,
+    resolveDependency,
   }
 }