fix: don't reexport vi utils from vitest (#1100)

vitest-dev · Apr 5, 2022 · 6f55275 · 6f55275
1 parent b24fb25
commit 6f55275
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/vitest/src/index.ts b/packages/vitest/src/index.ts
@@ -7,7 +7,7 @@ export * from './runtime/hooks'
 
 export { runOnce, isFirstRun } from './integrations/run-once'
 export * from './integrations/chai'
-export * from './integrations/spy'
+export type { EnhancedSpy, SpyInstance, SpyInstanceFn, SpyContext } from './integrations/spy'
 export * from './integrations/vi'
 export * from './integrations/utils'
 

diff --git a/packages/vitest/src/integrations/vi.ts b/packages/vitest/src/integrations/vi.ts
@@ -201,7 +201,7 @@ class VitestUtils {
    * using jsdom/happy-dom and want to mock global variables, like
    * `IntersectionObserver`.
    */
-  public stubGlobal(name: string, value: any) {
+  public stubGlobal(name: string | symbol | number, value: any) {
     // @ts-expect-error we can do anything!
     globalThis[name] = value
     if (globalThis.window)

diff --git a/test/core/test/spy.test.ts b/test/core/test/spy.test.ts
@@ -1,12 +1,12 @@
-import { describe, expect, spyOn, test } from 'vitest'
+import { describe, expect, test, vi } from 'vitest'
 
 /**
  * @vitest-environment happy-dom
  */
 
 describe('spyOn', () => {
   test('correctly infers method types', async() => {
-    spyOn(localStorage, 'getItem').mockReturnValue('world')
+    vi.spyOn(localStorage, 'getItem').mockReturnValue('world')
     expect(window.localStorage.getItem('hello')).toEqual('world')
   })
 })