fix: do not merge arrays (fix #725) (#728)

vitest-dev · Feb 11, 2022 · 92fb244 · 92fb244
1 parent 506cc20
commit 92fb244
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/packages/vitest/src/utils/base.ts b/packages/vitest/src/utils/base.ts
@@ -87,12 +87,6 @@ export function deepMerge<T extends object = object, S extends object = T>(targe
 
         deepMerge(target[key] as any, source[key] as any)
       }
-      else if (Array.isArray(source[key])) {
-        if (!target[key])
-          target[key] = [] as any
-
-        (target[key] as any).push(...source[key] as any)
-      }
       else {
         target[key] = source[key] as any
       }

diff --git a/test/core/test/utils.spec.ts b/test/core/test/utils.spec.ts
@@ -3,7 +3,7 @@ import { deepMerge } from '../../../packages/vitest/src/utils'
 import { deepMergeSnapshot } from '../../../packages/vitest/src/integrations/snapshot/port/utils'
 
 describe('deepMerge', () => {
-  test('non plain objects retain their prototype, arrays are merging, plain objects are merging', () => {
+  test('non plain objects retain their prototype, arrays are not merging, plain objects are merging', () => {
     class Test {
       baz = 'baz'
 
@@ -37,7 +37,7 @@ describe('deepMerge', () => {
 
     expect(merged.test instanceof Test).toBe(true)
     expect(merged.num).toBe(40)
-    expect(merged.array).toEqual([1, 2, 3, 4])
+    expect(merged.array).toEqual([3, 4])
     expect(merged.obj).toEqual({
       foo: 'foo',
       baz: 'baz',